FORMS-18761: Active user interface component lacks 3 to 1 contrast ratio @sunnym @vavarshn#26
Merged
vaibhav2601 merged 2 commits intomainfrom Jul 15, 2025
Merged
Conversation
Closed
10 tasks
Contributor
Author
|
Clones #25 (was PR from fork) |
akshayvas
reviewed
Jul 11, 2025
src/site/_variables.scss
Outdated
| $focus-outline: 2px $primary solid; | ||
| $error-outline: 2px $error solid; | ||
| $border-light: 2px $background-color solid; | ||
| $border-contrast: 2px $light-gray solid; |
Contributor
There was a problem hiding this comment.
@stefan-dragomir This is same as $border-dark token value.
Contributor
Author
There was a problem hiding this comment.
Removed it and changed the call in _mixins.
akshayvas
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
https://jira.corp.adobe.com/browse/FORMS-18761
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: